From d9d8b2678fed1de8242afe90c923b2d5d67eb516 Mon Sep 17 00:00:00 2001 From: Paul Semel Date: Mon, 12 Feb 2018 13:09:15 +0100 Subject: [PATCH] libxc: check for null size file mapping Changed the error message when trying to map a null size file. When doing `xl create` command, we get an Invalid Kernel error when the file size is greater than zero. For zero length files, we are falling in the mmap error, and we get an `Invalid parameter` error, which is not explicit. With this change, we get a `zero length file` error. Signed-off-by: Paul Semel Acked-by: Wei Liu --- tools/libxc/xc_dom_core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c index 96e71dd2d9..9bd04cb2d5 100644 --- a/tools/libxc/xc_dom_core.c +++ b/tools/libxc/xc_dom_core.c @@ -225,6 +225,12 @@ void *xc_dom_malloc_filemap(struct xc_dom_image *dom, "tried to map file which is too large"); goto err; } + else if ( !*size ) + { + xc_dom_panic(dom->xch, XC_INTERNAL_ERROR, + "'%s': zero length file", filename); + goto err; + } block = malloc(sizeof(*block)); if ( block == NULL ) { -- 2.30.2